Skip to content

[POS Orders] Enable pointOfSaleOrdersi1 #15887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2025
Merged

[POS Orders] Enable pointOfSaleOrdersi1 #15887

merged 4 commits into from
Jul 10, 2025

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Jul 9, 2025 •
edited
Loading

Description

This PR enables the feature flag pointOfSaleOrdersi1, launching POS Orders i1

Testing information

  • On a store with POS and WooCommerce 9.9+, process an order through POS.
  • Upon navigating to the orders tab, observe the POS badge appears both in order list and order details for those orders.
Tablet Order list Order details
Simulator Screenshot - iPad mini (A17 Pro) - US store - 2025-07-09 at 15 28 19 Simulator Screenshot - iPhone 16 Plus - US store - 2025-07-09 at 15 29 56 Simulator Screenshot - iPhone 16 Plus - US store - 2025-07-09 at 15 30 00

There are some accessibility improvements to be done as part of WOOMOB-751, but these are non-blocking for feature release and will be handled as part of backlog.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dangermattic
Copy link
Collaborator

dangermattic commented Jul 9, 2025 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 22.8. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@iamgabrielma iamgabrielma added feature: order details Related to order details. feature: order list Related to the order list. feature: POS labels Jul 9, 2025
@iamgabrielma iamgabrielma added this to the 22.8 milestone Jul 9, 2025
@iamgabrielma iamgabrielma added the type: task An internally driven task. label Jul 9, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review July 9, 2025 08:46
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 9, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15887-521dba4
Version22.7
Bundle IDcom.automattic.alpha.woocommerce
Commit521dba4
Installation URL21rsfi2pf5phg
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma requested a review from staskus July 9, 2025 08:50
staskus
staskus approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ I'm approving this.

❌ However, one thing that is not working properly is the "POS" badge is not reacting to dark/light mode changes. I need to kill and relaunch the app for the colors to change.

Simulator.Screen.Recording.-.iPad.Pro.11-inch.M4.-.2025-07-09.at.21.54.13.mov

@iamgabrielma
Copy link
Contributor Author

iamgabrielma commented Jul 10, 2025

Thanks for the review!

❌ However, one thing that is not working properly is the "POS" badge is not reacting to dark/light mode changes. I need to kill and relaunch the app for the colors to change.

Oh that's a great catch, appreciated.

So it would seem that if we initialize UIColors with UIColor(color: ... , we're creating static colors that don't respond to trait collection changes as they're unchanged for the whole app lifecycle, we have to initialize them dynamically instead.

Fixed on: 42c98a9

Screen.Recording.2025-07-10.at.11.37.35.mov

PD: I don't think the dark background is a great choice when we have a selected cell in iPad, I'll raise this with design

@iamgabrielma iamgabrielma enabled auto-merge July 10, 2025 04:41
@iamgabrielma iamgabrielma disabled auto-merge July 10, 2025 04:50
@iamgabrielma
Copy link
Contributor Author

iamgabrielma commented Jul 10, 2025

PD: I don't think the dark background is a great choice when we have a selected cell in iPad, I'll raise this with design

I've double checked the conversation where we updated them due to color conflicts ( p1751621596213999?thread_ts=1751347733.351649&cid=C070SJRA8DP-slack-C070SJRA8DP ) and it was my miss-understanding: Badge color shouldn't change based on light/dark appearance, we always use the same shade80/shade10 combination. I've updated this again on 521dba4 and now we're good to go 👍

Screen.Recording.2025-07-10.at.11.56.17.mov

@iamgabrielma iamgabrielma enabled auto-merge July 10, 2025 05:01
@iamgabrielma iamgabrielma merged commit 07919b7 into trunk Jul 10, 2025
13 checks passed
@iamgabrielma iamgabrielma deleted the task/enable-feature-flag-posorder-i1 branch July 10, 2025 05:18
@staskus
Copy link
Contributor

staskus commented Jul 10, 2025

I've updated this again on 521dba4 and now we're good to go 👍

Thanks, @iamgabrielma! Good we clarified 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staskus staskus staskus approved these changes

Assignees

No one assigned

Labels

feature: order details Related to order details. feature: order list Related to the order list. feature: POS type: task An internally driven task.

Projects

None yet

Milestone

22.8

Development

Successfully merging this pull request may close these issues.

5 participants

@iamgabrielma @dangermattic @wpmobilebot @staskus